Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: prepare for EmailMessage #143

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Sep 13, 2024

This is the beginning part of #142, without the move to email.message.EmailMessage.

Moving consumed API to only what is provided by EmailMessage.

  • .body -> .get_payload(), .set_payload()
  • .headers -> .items() and .get_all()
  • Order of insertion is now preserved exactly
  • Recommend / use bytes() over str()

We can restore .headers or .body if anyone is using them with a deprecation warning instead, but I didn't see anything beyond bytes() and str() from light searching.

Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii merged commit c2b77b2 into pypa:main Sep 13, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant